kola/tests: Add new cl.tpm.eventlog test for the TPM Event log #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was leaving the /tmp/mantle-ssh-* directory behind. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
21 tasks
chewi
force-pushed
the
chewi/tpm-event-log
branch
from
8bbe79a
to
94089fc
Compare
tormath1
reviewed
Sep 13, 2024
This will only work from GRUB 2.12 onwards, so restrict to 4082+. I initially wanted to add this check to the existing tpmTest function, but that wouldn't allow me to restrict the version. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
force-pushed
the
chewi/tpm-event-log
branch
from
94089fc
to
e147f08
Compare
2 tasks
tormath1
approved these changes
Sep 13, 2024
sayanchowdhury
approved these changes
Sep 16, 2024
We kind of stop adding changelog entries to Mantle (since we don't really handle release cycle for this as it's not rev in Flatcar via commit ID) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kola/tests: Add test for the TPM Event log
This will only work from GRUB 2.12 onwards, so restrict to 4082+. I initially wanted to add this check to the existing tpmTest function, but that wouldn't allow me to restrict the version.
flatcar/scripts#2318 should be merged first.
I also fixed a small bug while I was at it.
I think this is my first time writing Go, be nice. 😛
How to use
Testing done
I've run the above against an existing release image where it fails and my new GRUB 2.12 image where it passes. I have also tried the Docker image from this PR against that 9999.9.9+grub-2.12-1 Jenkins run. Both amd64 and arm64 pass.